Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for bad-staticmethod-argument #6002

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Added example for bad-staticmethod-argument #6002

merged 2 commits into from
Mar 28, 2022

Conversation

matusvalo
Copy link
Collaborator

Co-authored-by: Vladyslav Krylasov vladyslav.krylasov@gmail.com

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
✓ 📜 Docs

Description

Closes partially #5953

@matusvalo @sprytnyk
Added example for bad-staticmethod-argument
500053f 
Co-authored-by: Vladyslav Krylasov <vladyslav.krylasov@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2048792821

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.154%
Totals Coverage Status
Change from base Build 2047793050: 0.0%
Covered Lines: 15334
Relevant Lines: 16286
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion to make it more lively 😄

doc/data/messages/b/bad-staticmethod-argument/bad.py Outdated Show resolved Hide resolved
doc/data/messages/b/bad-staticmethod-argument/bad.py Outdated Show resolved Hide resolved
doc/data/messages/b/bad-staticmethod-argument/good.py Outdated Show resolved Hide resolved
doc/data/messages/b/bad-staticmethod-argument/good.py Outdated Show resolved Hide resolved
@matusvalo @Pierre-Sassoulas
Apply suggestions from code review
029a32d 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
@DanielNoord DanielNoord merged commit 1b85ca5 into pylint-dev:main Mar 28, 2022
@matusvalo matusvalo deleted the bad-staticmethod-argument branch March 28, 2022 09:05
@matusvalo
Copy link
Collaborator Author

@DanielNoord link in #5953 to this PR is missing.

@DanielNoord DanielNoord mentioned this pull request Mar 28, 2022
Closed
4 tasks
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.14.0 milestone Mar 28, 2022
@Pierre-Sassoulas Pierre-Sassoulas removed this from the 2.14.0 milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Documentation 📗
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matusvalo @coveralls @Pierre-Sassoulas @DanielNoord @jacobtylerwalls